Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change ray version and enable auto scaling #2821

Merged
merged 3 commits into from
Jul 30, 2024
Merged

change ray version and enable auto scaling #2821

merged 3 commits into from
Jul 30, 2024

Conversation

hansinikarunarathne
Copy link
Member

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

Updated the ray version and enable autoScaling

🐛 If this PR is related to an issue, please put the link to the issue here.

#2742

✅ Contributor checklist

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@hansinikarunarathne
change ray version and enable auto scaling
15afdc6 
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
@hansinikarunarathne
fix a issue
8d9b733 
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
@juliusvonkohout juliusvonkohout linked an issue Jul 29, 2024 that may be closed by this pull request
Update the ray example cluster to the stable v1 version and integrate istio #2742
Closed
7 tasks
@hansinikarunarathne
Add autoscaler options to ray
69f6703 
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Jul 30, 2024
@juliusvonkohout
Copy link
Member

There could be more outdated stuff that we should replace with upstream stuff.

For example this looks interesting. Maybe busybox is outdated.

        - name: init
          image: busybox:1.36
          # Change the cluster postfix if you don't have a default setting
          command: ['sh', '-c', "until nslookup $RAY_IP.$(cat /var/run/secrets/kubernetes.io/serviceaccount/namespace).svc.cluster.local; do echo waiting for K8s Service $RAY_IP; sleep 2; done"]

@juliusvonkohout
Copy link
Member

I think

Ray seems to have documentation for istio support now ray-project/ray#44801
ray-project/kuberay#1005
ray-project/kuberay#2117

Istio is something for a second PR. lets do a thorough cleanup here first and merge

@juliusvonkohout juliusvonkohout self-assigned this Jul 30, 2024
@juliusvonkohout
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 30, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2d77438 into kubeflow:master Jul 30, 2024
7 checks passed
@juliusvonkohout juliusvonkohout mentioned this pull request Jul 30, 2024
Closed
7 tasks
hansinikarunarathne added a commit to hansinikarunarathne/kubeflow-manifests that referenced this pull request Jul 30, 2024
@hansinikarunarathne
change ray version and enable auto scaling (kubeflow#2821)
69254ea 
* change ray version and enable auto scaling

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>

* fix a issue

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>

* Add autoscaler options to ray

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>

---------

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
@hansinikarunarathne
Copy link
Member Author

There could be more outdated stuff that we should replace with upstream stuff.

For example this looks interesting. Maybe busybox is outdated.

        - name: init
          image: busybox:1.36
          # Change the cluster postfix if you don't have a default setting
          command: ['sh', '-c', "until nslookup $RAY_IP.$(cat /var/run/secrets/kubernetes.io/serviceaccount/namespace).svc.cluster.local; do echo waiting for K8s Service $RAY_IP; sleep 2; done"]

can you elobrate on this comment more. It is little confusing

@hansinikarunarathne
Copy link
Member Author

There could be more outdated stuff that we should replace with upstream stuff.

For example this looks interesting. Maybe busybox is outdated.

        - name: init
          image: busybox:1.36
          # Change the cluster postfix if you don't have a default setting
          command: ['sh', '-c', "until nslookup $RAY_IP.$(cat /var/run/secrets/kubernetes.io/serviceaccount/namespace).svc.cluster.local; do echo waiting for K8s Service $RAY_IP; sleep 2; done"]

Can we update the ray cluster yaml as this with using a headless service?
https://docs.ray.io/en/latest/cluster/kubernetes/k8s-ecosystem/istio.html#step-4-create-the-raycluster

I started to go through the documents but did not find any clue as to what you were saying.

@juliusvonkohout
Copy link
Member

yes, just try something out :-)

pschoen-itsc pushed a commit to pschoen-itsc/kf-manifests that referenced this pull request Sep 3, 2024
@hansinikarunarathne @pschoen-itsc
change ray version and enable auto scaling (kubeflow#2821)
14b9086 
* change ray version and enable auto scaling

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>

* fix a issue

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>

* Add autoscaler options to ray

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>

---------

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusvonkohout juliusvonkohout Awaiting requested review from juliusvonkohout

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees

@juliusvonkohout juliusvonkohout

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the ray example cluster to the stable v1 version and integrate istio
2 participants
@hansinikarunarathne @juliusvonkohout